-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkpoint tools #885
Checkpoint tools #885
Conversation
* no changes other than names
* may remove and just modify IOManager
* it works!!! * checked against PlotfileToCSV routine
} | ||
|
||
[[nodiscard]] const DistributionMapping& | ||
DistributionMap(int level) const noexcept |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
totally minor: you seem to be following camelCase for all the other member functions but this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true! this is straight from "amrex/Src/Base/AMReX_PlotFileDataImpl.H" though
|
||
virtual ~CoarsenCheckpt() = default; | ||
|
||
void read_chkpt_add_baselevel(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and these are snake case ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bet it does look funny with the different cases! But this PR has a few tools in it. CoarsenCheckpt is separate from CheckpointToCSV. Each is different because of the code I started from.
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
@marchdf are you good with these changes? |
tools to